RFR: Epsilon GC

Roman Kennke rkennke at redhat.com
Thu Apr 26 18:32:55 UTC 2018


Hi Aleksey,

I like it! It is a nice testament to the GC interface work indeed :-)

I have nothing to complain about in the changeset, but I am not a
Reviewer either ;-)

Cheers, Roman

> Hi,
> 
> This is the review thread for Epsilon GC changes.
> 
> JEP, targeted to 11:
>   http://openjdk.java.net/jeps/318
>   (you can find links to binary builds and sandbox locations there)
> 
> Webrev:
>   http://cr.openjdk.java.net/~shade/epsilon/webrev.05/
> 
> Notes:
> 
>   *) See how the whole things is _almost_ drop-in to hotspot/share/gc, without having arch-specific
> mess -- thanks to GC interface work done over last years;
> 
>   *) There are some leftovers due to GC barriers work in progress: templateTable_arm.cpp addition
> goes away after JDK-8201786 [1], c1_LIRGenerator.cpp change should go away after C1 barriers
> modularization is complete, graphKit.cpp change should go away after C2 barriers modularization is
> complete;
> 
>   *) Half of the webrev are Epsilon-specific tests. They take ~30s in release and ~60s in fastdebug
> on my desktop. They are not in tier1, so smoke testing time is not affected;
> 
>   *) UseEpsilonGC is experimental. This should be fine after conditional GC compilation [2], so
> vendors who are unwilling to extend whatever small notion [3] of support comes with experimental VM
> option, may choose not to build it.
> 
> Testing: all platform builds, gc/epsilon on x86_64
> 
> Thanks,
> -Aleksey
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8201786
> [2] https://bugs.openjdk.java.net/browse/JDK-8200729
> [3] http://hg.openjdk.java.net/jdk/jdk/file/3661f31c6df4/src/hotspot/share/runtime/globals.hpp#l150
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20180426/152b5a96/signature-0001.asc>


More information about the hotspot-gc-dev mailing list