RFR (S/M): 8202017: Merge Reference Enqueuing phase with phase 3 of Reference processing

Thomas Schatzl thomas.schatzl at oracle.com
Fri Apr 27 09:11:56 UTC 2018


Hi Kim,

On Thu, 2018-04-26 at 19:03 -0400, Kim Barrett wrote:
> > On Apr 24, 2018, at 5:26 AM, Thomas Schatzl <thomas.schatzl at oracle.
> > com> wrote:
> > 
> > Hi Kim,
> > 
> > On Mon, 2018-04-23 at 19:10 -0400, Kim Barrett wrote:
> > > > 
> > > [...]
> > > This looks ripe for refactoring as part of the cleanup of CMS-
> > > specific intrusions.  Probably should have a followup RFE for
> > > this.
> > 
> > I will file an RFE for this.

Filed JDK-8202185 btw.

> > 
> > New webrevs:
> > http://cr.openjdk.java.net/~tschatzl/8202017/webrev.0_to_1 (diff)
> > http://cr.openjdk.java.net/~tschatzl/8202017/webrev.1/ (full)
> > 
> > Thomas
> 
> In the comment for G1CollectedHeap::make_pending_list_reachable():
>  516   // otherwise reachable ensure that it is marked in the bitmap
> for concurrent marking
> 
> s/reachable ensure/reachable. Ensure/
> 
> Otherwise looks good.  No need for a new webrev for that comment
> change.

I updated the webrev in place for the second reviewer.

Thanks for your review.

Thanks,
  Thomas


More information about the hotspot-gc-dev mailing list