RFR: 8202364: Add GCConfig::hs_err_name() to avoid GC-specific code in error reporting

Per Liden per.liden at oracle.com
Fri Apr 27 09:48:11 UTC 2018


On 04/27/2018 11:40 AM, Aleksey Shipilev wrote:
> On 04/27/2018 11:39 AM, Aleksey Shipilev wrote:
>> On 04/27/2018 11:33 AM, Per Liden wrote:
>>> The gc_mode() function in vmErrror.cpp currently tests which Use*GC flag is set and translates that
>>> into a name. We should instead call into GCConfig to get the name. This patch adds a new function
>>> (GCConfig::hs_err_name) for this purpose. This is not placed on CollectedHeap, since we might need
>>> this name before a CollectedHeap instance has been created, e.g. if we crash during VM startup.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8202364
>>> Webrev: http://cr.openjdk.java.net/~pliden/8202364/webrev.0
>>
>> Looks good.
> 
> Wait, except you want to keep the human-readable?

I though it looked ugly with the space so I removed it. I don't think it 
makes it less readable.

/Per


More information about the hotspot-gc-dev mailing list