PING: RFR: JDK-8153333: [REDO] STW phases at Concurrent GC should count in PerfCounter

Stefan Johansson stefan.johansson at oracle.com
Fri Feb 2 14:38:05 UTC 2018


Hi Yasumasa,

The changes doesn't apply clean on the latest jdk/hs, can you provide an 
updated webrev?

The testing done by the submit repo doesn't cover the tests you have 
update so I plan to take the change for a spin and make sure the correct 
tests are run and verified in Mach 5.

Also a question about the change. Why do we need a special flag for CMS? 
I see that the original bug report refers to the flag as being a way to 
turn on and off the feature but the current implementation only consider 
the flag for CMS.

Thanks,
Stefan

On 2018-02-01 14:58, Yasumasa Suenaga wrote:
> PING: Could you review and sponsor it?
>
>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8153333/webrev.04/
>
> This change has been passed Mach 5 via submit repo:
> http://java.se.oracle.com:10065/mdash/jobs/mach5-one-ysuenaga-JDK-8153333-20180201-0805-10101
>
>
> Thanks,
>
> Yasumasa
>
>
> On 2017/11/01 22:02, Yasumasa Suenaga wrote:
>> PING: Could you review and sponsor it?
>>
>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8153333/webrev.04/
>>
>> Also I need JPRT results of this change.
>> Could you cooperate?
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>> On 2017/09/27 0:08, Yasumasa Suenaga wrote:
>>> Hi all,
>>>
>>> I uploaded new webrev to be adapted to jdk10/hs:
>>>
>>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8153333/webrev.04/
>>>
>>> I want to check this patch via JPRT, but I cannot access it.
>>> Could you cooperate?
>>>
>>>
>>> Thanks,
>>>
>>> yasumasa
>>>
>>>
>>> On 2017/09/21 7:46, Yasumasa Suenaga wrote:
>>>> PING:
>>>>
>>>> Have you checked this issue?
>>>>
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8153333/webrev.03/hotspot/
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8153333/webrev.03/jdk/
>>>>
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> On 2017/07/01 23:44, Yasumasa Suenaga wrote:
>>>>> PING:
>>>>>
>>>>> Have you checked this issue?
>>>>>
>>>>>
>>>>> Yasumasa
>>>>>
>>>>>
>>>>> On 2017/06/14 13:22, Yasumasa Suenaga wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> I changed PerfCounter to show CGC STW phase in jstat in JDK-8151674.
>>>>>> However, it occurred several jtreg test failure, so it was 
>>>>>> back-outed.
>>>>>>
>>>>>> I want to resume to work for this issue.
>>>>>>
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8153333/webrev.03/hotspot/
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8153333/webrev.03/jdk/
>>>>>>
>>>>>> These changes are work fine on jtreg test as below:
>>>>>>
>>>>>>    hotspot/test/serviceability/tmtools/jstat
>>>>>>    jdk/test/sun/tools
>>>>>>
>>>>>>
>>>>>> Since JDK 9, default GC algorithm is set to G1.
>>>>>> So I think this change is useful to watch GC behavior through jstat.
>>>>>>
>>>>>> I cannot access JPRT. Could you help?
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Yasumasa
>>>>>>



More information about the hotspot-gc-dev mailing list