RFR: 8187577: JVM crash during gc doing concurrent marking

Poonam Parhar poonam.bajaj at oracle.com
Wed Feb 7 17:05:44 UTC 2018


Thanks Thomas and Coleen! I will add INCLUDE_ALL_GCs around the #include.

regards,
Poonam

On 2/7/2018 7:07 AM, coleen.phillimore at oracle.com wrote:
>
> Poonam, this looks good and I don't need to see another webrev with 
> INCLUDE_ALL_GCs around the #include.
>
> On 2/7/18 9:46 AM, Thomas Schatzl wrote:
>> Hi,
>>
>> On Wed, 2018-02-07 at 06:39 -0800, Poonam Parhar wrote:
>>> Hello Coleen, Kim,
>>>
>>> Thanks for your review! I moved ensure_klass_alive() to
>>> jvmtiGetLoadedClasses.cpp. Please take a look at the following
>>> webrev:
>>>
>>> http://cr.openjdk.java.net/~poonam/8187577/webrev.01/
>>    the include declaration should be guarded by #if INCLUDE_ALL_GCS.
>> I do not need a re-review of that change.
>>
>> @coleen: when I was looking at the change earlier I also thought
>> whether there shouldn't be something in the AccessAPI or another more
>> generic mechanism in the future. Thanks for handling this.
>
> Yes, we're going to change this hopefully soon.
>
> Thanks,
> Coleen
>>
>> Thanks,
>>    Thomas
>>
>



More information about the hotspot-gc-dev mailing list