RFR (S): 7127700: G1: Replace G1PLAB with PLAB

Stefan Johansson stefan.johansson at oracle.com
Tue Feb 13 10:35:47 UTC 2018



On 2018-02-13 09:51, Thomas Schatzl wrote:
> Hi Kim, Stefan,
>
>    thanks for your reviews.
>
> On Tue, 2018-02-13 at 01:55 -0500, Kim Barrett wrote:
>>> On Feb 12, 2018, at 10:21 AM, Stefan Johansson <stefan.johansson at or
>>> acle.com> wrote:
>>>
>>> Hi Thomas,
>>>
>>> On 2018-02-12 10:30, Thomas Schatzl wrote:
>>>> Hi all,
>>>>
>>>>    can I have reviews for this small change that removes G1PLAB
>>>> and uses the PLAB class throughout?
>>>>
>>>> Although the CR indicates that the remaining _retired member of
>>>> G1PLAB might be useful, I think the additional check it provides
>>>> is not worth the effort, so I removed it.
>>>>
>>>> CR:
>>>> https://bugs.openjdk.java.net/browse/JDK-7127700
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~tschatzl/7127700/webrev/
>>> Looks good, just one thing. Please remove the virtual declarations
>>> from PLAB in plab.hpp.
> Done, see
> http://cr.openjdk.java.net/~tschatzl/7127700/webrev.1 (full)
> http://cr.openjdk.java.net/~tschatzl/7127700/webrev/.0_to_1
> (diff)
Looks good!

Thanks,
Stefan
>
> webrevs.
>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list