RFR(s): 8197992: Move the OopStorage::ParState type out of inline.hpp

Kim Barrett kim.barrett at oracle.com
Thu Feb 15 16:19:36 UTC 2018


> On Feb 15, 2018, at 4:31 AM, Per Liden <per.liden at oracle.com> wrote:
> 
> Please view this patch, which moves the OopStorage::ParState type out from oopStorageParState.inline.hpp and into a new oopStorageParState.hpp. The functions depending on other .inline.hpp includes remain in oopStorageParState.inline.hpp.
> 
> This patch is needed to allow classes defined in other .hpp files to contain a oopStorage::ParState instance by value (without having inline.hpp includes in .hpp file). ZGC's ZRootIterator is an example of this.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8197992
> Webrev: http://cr.openjdk.java.net/~pliden/8197992/webrev.0/
> Testing: hs-tier1
> 
> /Per

The definition of the AlwaysTrueFn class can be left in the .inline; it is referenced (and can only
be referenced) from code in that file.

Otherwise, looks good.  Thanks for taking care of this gaffe on my part.

I don’t need a new webrev if you move the AlwaysTrueFn definition back.



More information about the hotspot-gc-dev mailing list