RFR: 8198528: Move GenerationSpecs from GenCollectorPolicy to GenCollectedHeap

Stefan Johansson stefan.johansson at oracle.com
Thu Feb 22 14:00:46 UTC 2018



On 2018-02-22 14:59, Per Liden wrote:
> On 02/22/2018 02:51 PM, Stefan Karlsson wrote:
>> On 2018-02-22 14:48, Per Liden wrote:
>>> Looks good.
>>
>> Thanks!
>>
>>>
>>> Just one thing...
>>>
>>> src/hotspot/share/gc/shared/genCollectedHeap.cpp
>>> ------------------------------------------------
>>>
>>>    70   _young_gen_spec(new GenerationSpec(young,
>>>    71 policy->initial_young_size(),
>>>    72 policy->max_young_size(),
>>>    73 policy->gen_alignment())),
>>>    74   _old_gen_spec(new GenerationSpec(old,
>>>    75 policy->initial_old_size(),
>>>    76 policy->max_old_size(),
>>>    77 policy->gen_alignment())),
>>>
>>> I'd like to see _young_gen_spec/_old_gen_spec be converted to values 
>>> instead of pointers to values, but that can come in a follow up RFE 
>>> is you prefer.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8198555
>
> Thanks!
>
>>
>> I also replaced some usages of young/old_gen_spec() with direct 
>> accesses to _young/old_gen_spec.
>>
>> http://cr.openjdk.java.net/~stefank/8198528/webrev.02.delta/
>> http://cr.openjdk.java.net/~stefank/8198528/webrev.02/
>
> Looks good!
>
+1
StefanJ
> /Per
>
>>
>> Thanks,
>> StefanK
>>
>>>
>>> /Per
>>>
>>> On 02/21/2018 10:27 PM, Stefan Karlsson wrote:
>>>> Hi all,
>>>>
>>>> Please review this patch to move _young_gen_spec and _old_gen_spec 
>>>> out from GenCollectorPolicy into GenCollectedHeap.
>>>>
>>>>   http://cr.openjdk.java.net/~stefank/8198528/webrev.01/
>>>>   https://bugs.openjdk.java.net/browse/JDK-8198528
>>>>
>>>> This is a step towards the removal of CollectorPolicy:
>>>>
>>>>   https://bugs.openjdk.java.net/browse/JDK-8198505
>>>>
>>>> Thanks,
>>>> StefanK



More information about the hotspot-gc-dev mailing list