RFR: 8198530: Move _gc_policy_counters from GenCollectorPolicy to GenCollectedHeap

Stefan Johansson stefan.johansson at oracle.com
Thu Feb 22 15:43:48 UTC 2018


Looks good,
StefanJ

On 2018-02-22 10:50, Stefan Karlsson wrote:
> Thanks for the review!
>
> StefanK
>
> On 2018-02-22 06:00, Kim Barrett wrote:
>>> On Feb 21, 2018, at 11:43 PM, Kim Barrett <kim.barrett at oracle.com> 
>>> wrote:
>>>
>>>> On Feb 21, 2018, at 5:00 PM, Stefan Karlsson 
>>>> <stefan.karlsson at oracle.com> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> Please review this patch to move _gc_policy_counters from 
>>>> GenCollectorPolicy to GenCollectedHeap.
>>>>
>>>> http://cr.openjdk.java.net/~stefank/8198530/webrev.01/
>>>> https://bugs.openjdk.java.net/browse/JDK-8198530
>>>>
>>>> This is a step towards the removal of CollectorPolicy:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8198505
>>>>
>>>> Thanks,
>>>> StefanK
>>>
>>> This looks ok, except I was expecting to find some new 
>>> gcPolicyCounters files in here.
>>> Are those missing?  Or are they in one of the other webrevs? Or are 
>>> they in some patch
>>> still pending patch in your queue for this work, and should have 
>>> been included here?
>>
>> Oh, never mind.  I got confused between new and deleted code. They 
>> already exist.
>>
>> Looks good.
>>



More information about the hotspot-gc-dev mailing list