RFR (round 2), JEP-318: Epsilon GC

Leonid Mesnik leonid.mesnik at oracle.com
Fri May 11 18:52:48 UTC 2018



> On May 11, 2018, at 9:37 AM, Aleksey Shipilev <shade at redhat.com> wrote:
> 
> Hi Leonid,
> 
> On 05/09/2018 08:08 PM, Leonid Mesnik wrote:
>> I haven't review all changes. Just have a couple of small comments about tests. 
>> 1) It makes a sense to add @requires tag to all epsilon tests like it is done for other GC-specific
>> tests. So jtreg filter them out if epsilon GC is not supported or any other GC is set in
>> command-line explicitly.
> 
> Yes, very nice!
> 
>> 2) Also I don't see why these tests are not in tier1. 
>> 
>> Group tier1_gc_2 includes all tests in gc/ until they are excluded explicitly. So you need to
>> exclude gc/epsilon tests from it.
> 
> I thought that tier1 is a bunch of carefully selected tests. But it seems the long-running tests are
> just selected out of tier1. Ok, I put Epsilon tests to tier1!
> 
> This is the change that implements both:
>  http://hg.openjdk.java.net/jdk/sandbox/rev/ada11a8e2ebc
> 
> Is this what you had in mind?

Yes, thanks for fixing this.

Leonid
> 
> -Aleksey
> 
> 



More information about the hotspot-gc-dev mailing list