RFR (XS): JDK-8204084: Remove the G1RSBarrierRegionFilter develop flag
shade at redhat.com
Wed May 30 10:15:21 UTC 2018
On 05/30/2018 12:08 PM, Thomas Schatzl wrote:
> can I have reviews for this small change that removes the
> G1RSBarrierRegionFilter develop flag from G1 code that is implemented
> in a very incomplete way, and since I do not see a point fixing that I
> suggest removing it.
Yup. Amusingly, this filter is implemented in shared C1  and C2  code, where the performance
does matter, and it is not hooked up to the flag :) It might indeed make little sense to perform
this filtering in arch-specific interpreter barriers.
I think you want to remove the comments like:
273 // Does store cross heap regions?
274 // It does if the two addresses specify different grain addresses.
222 // Crosses regions, storing NULL?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: OpenPGP digital signature
More information about the hotspot-gc-dev