RFR (S): 8204081: Mismatch in rebuild policy and collection set chooser causes remembered sets to be kept errorneously

Kim Barrett kim.barrett at oracle.com
Wed May 30 20:29:39 UTC 2018


> On May 30, 2018, at 8:58 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8204081
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8204081/webrev/
> Testing:
> hs-tier1-3,jdk-tier1-2
> 
> Thanks,
>  Thomas

Looks good.

One minor thing:

src/hotspot/share/gc/g1/collectionSetChooser.cpp
 241     } else if (r->is_old()) {
...
 245     } else {
 246       assert(!r->is_old() || !r->rem_set()->is_tracked(),

The !r->is_old() in the assert seems redundant.

I don't need a new webrev if you remove that expression.



More information about the hotspot-gc-dev mailing list