RFR: 8213224: Move code related to GC threads calculation out of AdaptiveSizePolicy

Per Liden per.liden at oracle.com
Mon Nov 5 08:20:50 UTC 2018


Hi,

On 11/1/18 6:49 PM, Man Cao wrote:
> Hi all,
> 
> Could anyone review this cleanup change?
> In addition to straight code movement, it removes unnecessary dependency 
> on adaptiveSizePolicy.hpp in G1 code, and removed unnecessary include 
> statements in adaptiveSizePolicy.hpp/cpp.
> 
> Webrev: https://cr.openjdk.java.net/~manc/8213224/webrev.00/
> RFE: https://bugs.openjdk.java.net/browse/JDK-8213224

Removing these function from AdaptiveSizePolicy might be a good idea, 
but I'm not sure they fit very well into the WorkerManager class, which 
is a backend for AbstractWorkGang and GCTaskManager. These functions 
might fit better into a new WorkerPolicy class. Such a class could also 
be the new home for these function (which currently sit is an very odd 
place):

Abstract_VM_Version::nof_parallel_worker_threads();
Abstract_VM_Version::parallel_worker_threads();
Abstract_VM_Version::calc_parallel_worker_threads();

cheers,
Per

> Tested on submit repo with the help from JC (CCed).
> 
> Thanks,
> Man


More information about the hotspot-gc-dev mailing list