RFR: JDK-8213371: GC/C2 abstraction and cleanup to handle custom offset for GC memory accesses

Roman Kennke rkennke at redhat.com
Mon Nov 5 15:34:21 UTC 2018


 There are a few places in C2 where we need to deal with Shenandoah's
custom offset to load the forwarding pointer.

This patch:
- Adds hook and verification to allow GC to flatten/initialize an alias
type for (e.g.) fwd ptr accesses (btw: the 'to' field in compile.cpp
around the changed code is unused)
- in memnode.cpp removes the (unnecessary?) cast from ints to uints
- in type.cpp, make the offset check more explicit about offset > 0 or
the two predefined offsets that could be negative.

The latter two are related to the change insofar that they conflict with
Shenandoah's -8 offset, which would require extra handling without those
cleanups. Let me know if you want those changes separate.

Testing: hotspot/jtreg:tier1

Bug:
https://bugs.openjdk.java.net/browse/JDK-8213371
Webrev:
http://cr.openjdk.java.net/~rkennke/JDK-8213371/webrev.00/

Can I please get a review?

Roman

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20181105/e84b66d9/signature-0001.asc>


More information about the hotspot-gc-dev mailing list