RFR (XS): 8213113: Dead code related to UseAdaptiveSizePolicy in ParNewGeneration

Man Cao manc at google.com
Mon Nov 5 22:28:09 UTC 2018


Hi,

Thanks for the review, Per.

Removing them sounds good, new webrev:
https://cr.openjdk.java.net/~manc/8213113/webrev.01/

Thanks,
Man


On Mon, Nov 5, 2018 at 1:13 AM Per Liden <per.liden at oracle.com> wrote:

> Hi,
>
> On 10/31/18 9:51 PM, Man Cao wrote:
> > Hi all,
> >
> > Could anyone review this small clean up? I discovered it while working
> > on refactoring code in adaptiveSizePolicy.hpp/cpp.
> > Webrev: https://cr.openjdk.java.net/~manc/8213113/webrev.00/
> > RFE: https://bugs.openjdk.java.net/browse/JDK-8213113
>
> Please also remove the calls to minor_collection_begin() and
> minor_collection_end(), otherwise this goes from a trivial "remove dead
> code" fix to a change in the actual logic. If these calls are needed at
> some point in the future (which I doubt given that CMS is deprecated and
> will likely go away soon), they can be added then.
>
> cheers,
> Per
>
> > Tested on submit repo with the help from JC (CCed).
> >
> > Thanks,
> > Man
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20181105/48faeac6/attachment.html>


More information about the hotspot-gc-dev mailing list