RFR: 8213224: Move code related to GC threads calculation out of AdaptiveSizePolicy

Man Cao manc at google.com
Tue Nov 6 02:30:47 UTC 2018


Hi,

Thanks for the review!
I moved those 3 functions and created a new WorkerPolicy class as suggested.
New webrev: https://cr.openjdk.java.net/~manc/8213224/webrev.01/

There's a Sparc-specific heuristic for
VM_Version::calc_parallel_worker_threads().
I added a function
Abstract_VM_Version::parallel_worker_threads_denominator() in order to keep
this behavior and minimize relevant code in VM_Version class.
I also changed "unsigned int" to "uint", for the functions from VM_Version.

Now the change in workerManager.hpp is only trivial code movement and
improving #include statements.

Thanks,
Man


On Mon, Nov 5, 2018 at 12:20 AM Per Liden <per.liden at oracle.com> wrote:

> Hi,
>
> On 11/1/18 6:49 PM, Man Cao wrote:
> > Hi all,
> >
> > Could anyone review this cleanup change?
> > In addition to straight code movement, it removes unnecessary dependency
> > on adaptiveSizePolicy.hpp in G1 code, and removed unnecessary include
> > statements in adaptiveSizePolicy.hpp/cpp.
> >
> > Webrev: https://cr.openjdk.java.net/~manc/8213224/webrev.00/
> > RFE: https://bugs.openjdk.java.net/browse/JDK-8213224
>
> Removing these function from AdaptiveSizePolicy might be a good idea,
> but I'm not sure they fit very well into the WorkerManager class, which
> is a backend for AbstractWorkGang and GCTaskManager. These functions
> might fit better into a new WorkerPolicy class. Such a class could also
> be the new home for these function (which currently sit is an very odd
> place):
>
> Abstract_VM_Version::nof_parallel_worker_threads();
> Abstract_VM_Version::parallel_worker_threads();
> Abstract_VM_Version::calc_parallel_worker_threads();
>
> cheers,
> Per
>
> > Tested on submit repo with the help from JC (CCed).
> >
> > Thanks,
> > Man
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20181105/3123e6b2/attachment.html>


More information about the hotspot-gc-dev mailing list