RFR (XS): 8213113: Dead code related to UseAdaptiveSizePolicy in ParNewGeneration
manc at google.com
Thu Nov 8 18:54:50 UTC 2018
Thank you for the code review!
On Wed, Nov 7, 2018 at 11:12 PM Per Liden <per.liden at oracle.com> wrote:
> On 2018-11-05 23:28, Man Cao wrote:
> > Hi,
> > Thanks for the review, Per.
> > Removing them sounds good, new webrev:
> > https://cr.openjdk.java.net/~manc/8213113/webrev.01/
> > <https://cr.openjdk.java.net/%7Emanc/8213113/webrev.01/>
> Looks good.
> > Thanks,
> > Man
> > On Mon, Nov 5, 2018 at 1:13 AM Per Liden <per.liden at oracle.com
> > <mailto:per.liden at oracle.com>> wrote:
> > Hi,
> > On 10/31/18 9:51 PM, Man Cao wrote:
> > > Hi all,
> > >
> > > Could anyone review this small clean up? I discovered it while
> > working
> > > on refactoring code in adaptiveSizePolicy.hpp/cpp.
> > > Webrev: https://cr.openjdk.java.net/~manc/8213113/webrev.00/
> > <https://cr.openjdk.java.net/%7Emanc/8213113/webrev.00/>
> > > RFE: https://bugs.openjdk.java.net/browse/JDK-8213113
> > Please also remove the calls to minor_collection_begin() and
> > minor_collection_end(), otherwise this goes from a trivial "remove
> > code" fix to a change in the actual logic. If these calls are needed
> > some point in the future (which I doubt given that CMS is deprecated
> > and
> > will likely go away soon), they can be added then.
> > cheers,
> > Per
> > > Tested on submit repo with the help from JC (CCed).
> > >
> > > Thanks,
> > > Man
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev