RFR (M): 8212657: Implementation of JDK-8204089 Promptly Return Unused Committed Memory from G1 [Was: RFR (M): 8212657: Implementation of JDK-8204089 Timely Reduce Unused Committed Memory]

Thomas Schatzl thomas.schatzl at oracle.com
Thu Nov 15 13:57:29 UTC 2018


Hi Stefan,

  thanks for your review.

On Thu, 2018-11-15 at 11:56 +0100, Stefan Johansson wrote:
> Hi Thomas,
> 
> Just a few comments on the current patch.
> 
[...]
>
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8212657
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8212657/webrev/index.html
> 
> 
[some comments]

Fixed in 

http://cr.openjdk.java.net/~tschatzl/8212657/webrev.0_to_1 (diff)
http://cr.openjdk.java.net/~tschatzl/8212657/webrev.1 (full)


This also contains the change to the default value of
G1PeriodicGCInterval to 0 (disabled).

This does not mean this is set in stone right now (or the value/name or
anything). Just that opinions so far tend to go into this direction.

> 
> Otherwise I think this looks good.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list