RFR (M): 8213996: Remove one of the SparsePRT entry tables

Thomas Schatzl thomas.schatzl at oracle.com
Tue Nov 20 14:21:43 UTC 2018


Hi all,

On Fri, 2018-11-16 at 21:59 +0100, Thomas Schatzl wrote:
> Hi Aleksey,
> 
> On Fri, 2018-11-16 at 18:15 +0100, Aleksey Shipilev wrote:
> > On 11/16/2018 03:19 PM, Thomas Schatzl wrote:
> > > CR:
> > > https://bugs.openjdk.java.net/browse/JDK-8213996
> > > Webrev:
> > > http://cr.openjdk.java.net/~tschatzl/8213996/webrev
> > 
> > Looks like a good cleanup!
> > 
> > Nit;
> > 
> > *) g1ConcurrentMark.cpp: missing space here:
> > 
> > 1231       _humongous_regions_removed(0){ }
> > 
> > -Aleksey
> > 
> 
>   thanks for the review.
> 
> Unfortunately stress testing on some benchmarks with a release build
> revealed that there is a bug somewhere, so I want to retract this
> review for now.

  the crashes seem unrelated as they are reproducable with very similar
patterns in older builds too (JDK-8214118).

So I think I can safely reopen this review again. I fixed Aleksey's nit
and also found a few more unused methods to remove.

http://cr.openjdk.java.net/~tschatzl/8213996/webrev.0_to_1/ (diff)
http://cr.openjdk.java.net/~tschatzl/8213996/webrev.1/ (full)

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list