RFR: 8214144: Remove confusing locking_enqueue_completed_buffer

Kim Barrett kim.barrett at oracle.com
Wed Nov 21 13:41:25 UTC 2018


> On Nov 21, 2018, at 4:20 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On Tue, 2018-11-20 at 17:40 -0500, Kim Barrett wrote:
>> Please review this trivial change to remove the confusingly named
>> function PtrQueue::locking_enqueue_completed_buffer, inlining its
>> simple definition at the single call site.  It used to be more
>> complicated and "interesting", but was gutted by JDK-8182703.
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8214144
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8214144/open.00/
>> 
>> Testing:
>> Locally (linux-x64) built and ran hotspot_tier1 tests.
>> 
> 
>  looks good. Seems trivial to me.
> 
> Thanks,
>  Thomas

Thanks.



More information about the hotspot-gc-dev mailing list