RFR: 8214202: DirtyCardQueueSet::get_completed_buffer should not clear _process_completed

Kim Barrett kim.barrett at oracle.com
Mon Nov 26 18:05:31 UTC 2018


> On Nov 26, 2018, at 3:44 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
> 
> 
> 
> On 2018-11-22 08:04, Kim Barrett wrote:
>> Please review this small fix for get_completed_buffer.  As discussed
>> in the CR, it should not be setting _process_completed to false when
>> the stop_at limit has been reached.
>> 
>> While I was there, simplified the code a little, eliminating an
>> unnecessary NULL test.
>> 
>> Also fixed a mistaken use of _process_completed in an assert message,
>> spotted while examining all uses of that variable.
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8214202
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8214202/open.00/
> Looks good,
> Stefan
> 
>> Testing:
>> mach5 tier1-3.

Thanks.



More information about the hotspot-gc-dev mailing list