RFR 8204947: Port ShenandoahTaskTerminator to mainline and make it default

Roman Kennke rkennke at redhat.com
Thu Nov 29 22:22:07 UTC 2018


Hi Kim,

>>
>> I believe if you add a flag, you need to file a CSR.
> 
> Experimental and diagnositc options don't need a CSR.  From the CSR FAQ: 
> https://wiki.openjdk.java.net/display/csr/CSR+FAQs
> 
> "Interfaces that are experimental or for diagnostic purposes do not
> need to go through CSR process, but the CSR process may be employed if
> feedback from the CSR reviewers is desired."
> 
> That's a relatively recent change (this calendar year).

Interesting! Does that mean that, strictly speaking, we don't need a CSR
for Shenandoah flags? :-)

(In any event, it would be nice if you or somebody else from hotspot-gc
could review it:
https://bugs.openjdk.java.net/browse/JDK-8214349 )

> I also think what's being proposed here is more of a diagnostic than
> experimental flag.  I think an experimental flag ought to be opt-in,
> e.g. off by default but one can choose to take the risk.  A diagnostic
> flag can be used to opt-out of the "normal" behavior, in this case to
> revert back to the old behavior.  Of course, we violate that a lot...

I agree. Diagnostic seems to fit the purpose better.

Roman


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20181129/404bfa32/signature.asc>


More information about the hotspot-gc-dev mailing list