RFR: 8211446: Replace oop_pc_follow_contents with oop_iterate and closure

Stefan Johansson stefan.johansson at oracle.com
Tue Oct 9 14:55:39 UTC 2018


Looks good,
StefanJ

On 2018-10-09 15:52, Leo Korinth wrote:
> Hi!
> 
> Here are new incremental and full webrevs that tries to improve the code 
> according to suggestions from Stefan and Thomas.
> 
> incremental:
> http://cr.openjdk.java.net/~lkorinth/8211446/00-01/
> full:
> http://cr.openjdk.java.net/~lkorinth/8211446/01/
> 
> Thanks,
> Leo
> 
> On 09/10/2018 11:00, Thomas Schatzl wrote:
>> Hi,
>>
>> On Thu, 2018-10-04 at 18:27 +0200, Leo Korinth wrote:
>>> Hi!
>>>
>>> This is the is the second enhancement in a series of three to remove
>>> Parallel GC specific behaviour from shared code. I will post all
>>> three enhancements to the mailing list.
>>>
>>> For a description on what is changed see my earlier "RFR: 8201436:
>>> Replace oop_ps_push_contents with oop_iterate and closure"
>>>
>>> Enhancement:
>>> https://bugs.openjdk.java.net/browse/JDK-8211446
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~lkorinth/8211446/00/
>>
>> Some minor issues:
>>
>> - psCompactionManager.inline.hpp:96: remove two of the newlines
>>
>> - psCompactionManager.inline.hpp: please fix indentation of
>> PSMarkAndPushClosure and PSIterateMarkAndPushClosure class
>> declarations.
>>
>> - the "pc" vs. "ps" prefixes Stefan already mentioned.
>>
>> Thanks,
>>    Thomas
>>


More information about the hotspot-gc-dev mailing list