RFR(S) : 8157728 : Covert GCTimer_test to GTest

David Holmes david.holmes at oracle.com
Wed Oct 10 01:49:08 UTC 2018


Hi Igor,

Not a review - I fixed the typo in the bug synopsis: Covert -> Convert :)

Please ensure you commit with corrected synopsis.

Thanks,
David

On 10/10/2018 3:23 AM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8157728/webrev.00/index.html
>> 450 lines changed: 238 ins; 211 del; 1 mod;
> 
> Hi all,
> 
> could you please review this small (and hopefully trivial) patch which converts internal GCTimer_test to gtest?
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8157728/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8157728
> testing:
>   - converted tests on linux-x64, windows-x64, macosx-x64, solaris-sparcv9 in product and fastdebug variants
>   - build w/ precompiled-headers enabled and disabled
> 
> PS the patch has been originally created by Kirill Zh, but hasn't been sent out for official review
> 
> Thanks,
> -- Igor
>   
> 


More information about the hotspot-gc-dev mailing list