RFR: JDK-8211955: GC abstraction for LAB reserve

Roman Kennke rkennke at redhat.com
Wed Oct 10 21:08:41 UTC 2018


Hi Aleksey,

>> Incremental:
>> http://cr.openjdk.java.net/~rkennke/JDK-8211955/webrev.01.diff/
>> Full:
>> http://cr.openjdk.java.net/~rkennke/JDK-8211955/webrev.01/
> 
> I think you were right with "dummy" name symmetry, but I have not strong opinion either.

Haha, ok. Let's change it back, but without words, ok?

> In plab.cpp, this header is not needed anymore?
>   30 #include "oops/arrayOop.hpp"

Right. Fixed.

> ...and maybe not even this one?
>   31 #include "oops/oop.inline.hpp"

Still needed elsewhere I think.

>> Let's wait for the Epsilon test fix...
> 
> FWIW, the running with candidate fix for JDK-8212005 applied passes x86_32 tier1_gc.

Ok, cool. Here's the updated webrevs:
Incremental:
http://cr.openjdk.java.net/~rkennke/JDK-8211955/webrev.02.diff/
Full:
http://cr.openjdk.java.net/~rkennke/JDK-8211955/webrev.02/

Good now?

Roman

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20181010/1e01aee7/signature-0001.asc>


More information about the hotspot-gc-dev mailing list