RFR (S) 8212083: Handle remaining gc/lock native code and fix two strings

JC Beyler jcbeyler at google.com
Mon Oct 15 19:04:56 UTC 2018


Thanks Thomas!

Here is the new webrev for the curious, which puts the includes in
lexicographical order:

Webrev: http://cr.openjdk.java.net/~jcbeyler/8212083/webrev.01/
And Bug is still here: https://bugs.openjdk.java.net/browse/JDK-8212083

I'll pass it through the submit repo and then, upon success I'll push it
with you and Paul as reviewers.

Thanks again,
Jc

On Mon, Oct 15, 2018 at 1:47 AM Thomas Schatzl <thomas.schatzl at oracle.com>
wrote:

> Hi,
>
> On Thu, 2018-10-11 at 15:23 -0700, JC Beyler wrote:
> > Hi all,
> >
> > I've cleaned up the gc/lock tests to use the ExceptionCheckingJniEnv
> > wrapper and now we have all JNI calls in that test group covered from
> > a "checking exceptions and returns of JNI methods".
> >
> > Let me know what you think:
> > Webrev: http://cr.openjdk.java.net/~jcbeyler/8212083/webrev.00/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8212083
> >
>
>   looks good to me as far as I understand the code. One nit: could you
> fix the #include declarations: they should be ordered
> lexicographically.
>
> Thanks,
>   Thomas
>
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20181015/8c2bad8d/attachment.html>


More information about the hotspot-gc-dev mailing list