RFR (XXS): 8210492: PLAB object promotion events report object sizes in words

Hohensee, Paul hohensee at amazon.com
Mon Oct 15 23:44:49 UTC 2018


Looks good to me.

Paul

From: hotspot-gc-dev <hotspot-gc-dev-bounces at openjdk.java.net> on behalf of JC Beyler <jcbeyler at google.com>
Date: Monday, October 15, 2018 at 5:35 PM
To: Thomas Schatzl <thomas.schatzl at oracle.com>
Cc: "hotspot-gc-dev at openjdk.java.net" <hotspot-gc-dev at openjdk.java.net>
Subject: Re: RFR (XXS): 8210492: PLAB object promotion events report object sizes in words

Hi Thomas,

Not a reviewer but looks good to me :)
Jc

On Mon, Oct 15, 2018 at 9:11 AM Thomas Schatzl <thomas.schatzl at oracle.com<mailto:thomas.schatzl at oracle.com>> wrote:
Hi all,

  can I have reviews for this trival fix that properly scales the
values passed on to JFR by HeapWordSize?

CR:
https://bugs.openjdk.java.net/browse/JDK-8210492
Webrev:
http://cr.openjdk.java.net/~tschatzl/8210492/webrev/
Testing:
hs-tier1-3,jdk-tier1-3

Thanks,
  Thomas



--

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20181015/afbf5796/attachment-0001.html>


More information about the hotspot-gc-dev mailing list