RFR(XS) : 8171097 : Convert TestReservedSpace_test to Gtest

Igor Ignatyev igor.ignatyev at oracle.com
Wed Oct 17 17:55:05 UTC 2018


Hi JC,

thanks for your review!

Cheers,
-- Igor

> On Oct 16, 2018, at 12:51 PM, JC Beyler <jcbeyler at google.com> wrote:
> 
> Hi Igor,
> 
> The change looks good to me, I compared old/new, the port looks good.
> 
> For the reviewers, here is the original test code:
> http://hg.openjdk.java.net/jdk/jdk/file/2e928420389d/src/hotspot/share/memory/virtualspace.cpp#l1071 <http://hg.openjdk.java.net/jdk/jdk/file/2e928420389d/src/hotspot/share/memory/virtualspace.cpp#l1071>
> 
> Thanks,
> Jc
> 
> On Tue, Oct 16, 2018 at 9:06 AM Igor Ignatyev <igor.ignatyev at oracle.com <mailto:igor.ignatyev at oracle.com>> wrote:
> http://cr.openjdk.java.net/~iignatyev//8171097/webrev.00/index.html <http://cr.openjdk.java.net/~iignatyev//8171097/webrev.00/index.html>
> > 188 lines changed: 187 ins; 1 del; 0 mod; 
> 
> Hi all,
> 
> could you please review this small (and hopefully trivial) patch which converts internal TestReservedSpace_test to gtest? 
> since the old test is still used by WhiteBox::runMemoryUnitTests, the old code hasn't been removed. it will be removed later when all 4 tests used by runMemoryUnitTests are converted.
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8171097/webrev.00/index.html <http://cr.openjdk.java.net/~iignatyev//8171097/webrev.00/index.html>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8171097 <https://bugs.openjdk.java.net/browse/JDK-8171097>
> testing:
> - converted tests on linux-x64, windows-x64, macosx-x64, solaris-sparcv9 in product and fastdebug variants 
> - build w/ precompiled-headers enabled and disabled
> 
> PS the patch has been originally created by Kirill Zh, but hasn't been sent out for official review
> 
> Thanks,
> -- Igor 
> 
> 
> -- 
> 
> Thanks,
> Jc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20181017/4a40d802/attachment.html>


More information about the hotspot-gc-dev mailing list