RFR: 8212595: Remove unused size_helper() in oop_oop_iterate* in instanceKlass.inline.hpp
leo.korinth at oracle.com
Thu Oct 18 09:10:26 UTC 2018
Thank you for the review.
On 17/10/2018 22:13, Per Liden wrote:
> Looks good.
> On 10/17/2018 05:24 PM, Leo Korinth wrote:
>> This is a small clean-up.
>> I am removing calls to size_helper() in instanceKlass.inline.hpp. The
>> size is never used, and the corresponding methods outside
>> InstanceKlass already returns void instead of int.
>> Fast disassembly inspection of the oop_oop_iterate_reverse version
>> reveals that the compiler output remains the same. That is, the
>> compiler already understood that the code was unused. No performance
>> improvement thus. The code becomes a bit simpler and corresponds
>> better to the methods in the other *Klass files.
>> - mach5 tier1-3
>> Thanks, Leo
More information about the hotspot-gc-dev