RFR (S): 8211388: Make OtherRegionsTable independent of the region it is for

sangheon.kim at oracle.com sangheon.kim at oracle.com
Mon Oct 29 22:05:03 UTC 2018


Hi Thomas,

On 10/15/18 3:59 AM, Thomas Schatzl wrote:
> Hi all,
>
>    ping for a second review...
>
> Thomas
>
> On Tue, 2018-10-02 at 17:58 +0200, Thomas Schatzl wrote:
>> Hi,
>>
>>    the OtherRegionsTable is a set of a set of cards that comprises the
>> remembered set.
>>
>> It stores the HeapRegion it collects cards for to do filtering in the
>> FromCardCache. The set of cards should not have knowledge about what
>> region it is for, from an abstraction POV it should just be a dumb
>> container of cards.
>>
>> Move out the HeapRegion id from OtherRegionsTable (the "set of
>> cards")
>> into the enclosing HeapRegionRememberedSet (managing set of cards),
>> separating the FCC functionality from the raw data storage.
>>
>> This will make code that assigns a HeapRegionRememberedSet to
>> multiple
>> regions in the future a bit simpler too.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8211388
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8211388/webrev/
Looks good.
But please modify below line before pushing it. I don't need extra 
webrev for this.

-------------------------------------------
src/hotspot/share/gc/g1/heapRegionRemSet.hpp

126   // Create a new remembered set for the given heap region. The given mutex should
127   // be used to ensure consistency.

- You removed heap region parameter, so some part of above comment 
should be modified. :)

Thanks,
Sangheon


>> Testing:
>> hs-tier1-3
>>
>> Thanks,
>>    Thomas
>>
>>
>



More information about the hotspot-gc-dev mailing list