RFR (S): 8210265: Crash in HSpaceCounters::update_used()

Thomas Schatzl thomas.schatzl at oracle.com
Tue Sep 4 08:29:30 UTC 2018


Hi,

On Mon, 2018-09-03 at 21:15 -0400, Kim Barrett wrote:
> > On Sep 3, 2018, at 6:56 AM, Thomas Schatzl <thomas.schatzl at oracle.c
> > om> wrote:
> > 
> > Hi all,
> > 
> >  can I have reviews for this change that fixes a crash when G1 is
> > started with -XX:-UsePerfData?
> > The reason has been that recent refactoring removed one "if
> > (UsePerfData)" check too many.
> > 
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8210265
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8210265/webrev/
> > Testing:
> > new test succeeds
> > 
> > Thanks,
> >  Thomas
> 
> Looks good.
> 

thanks for your review.

> However, I was wondering why we’re making these unusable
> HSpaceCounters at all.

  the _from_space_counters is there for backwards compatibility only
afaik.

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list