RFR (M): 8207200: Committed > max memory usage when getting MemoryUsage

Thomas Schatzl thomas.schatzl at oracle.com
Tue Sep 4 08:41:14 UTC 2018


Hi Mandy,

On Fri, 2018-08-24 at 09:06 -0500, mandy chung wrote:
> 
> On 8/24/18 5:17 AM, Thomas Schatzl wrote:
> > On Wed, 2018-08-08 at 17:15 +0200, Thomas Schatzl wrote:
> > > Hi all,
> > > 
> > >    can I have reviews for this change that fixes some races when
> > > reading from G1MonitoringSupport members, causing some assertion
> > > failing after weeks of running some programs that poll the G1
> > > MemoryPools.
> > > 
> > > It does so by adding a mutex that is held during reading and
> > > writing them.
> > > 
> > > There is also a new explicit call in CollectedHeap to get a
> > > consistent overall MemoryUsage information instead of the
> > > existing
> > > code looping over the heap's memory pools. That one is
> > > problematic
> > > too otherwise.
> > > 
> > > There is still no change in the calculation of the values of the
> > > MemoryUsage members.
> > > 
> > > CR:
> > > https://bugs.openjdk.java.net/browse/JDK-8207200
> > > Webrev:
> > > http://cr.openjdk.java.net/~tschatzl/8207200/webrev
> 
> This patch looks good to me AFAICT.

  thanks for your review.

Thomas


More information about the hotspot-gc-dev mailing list