RFR (XS) 8210192: Hsperf counter ParNew::CMS should be ParNew:CMS

Stefan Johansson stefan.johansson at oracle.com
Tue Sep 4 12:47:13 UTC 2018


Thanks for providing a test Man,

I've run the test through our test system to make sure it runs ok on our 
core platforms and it did.

This still looks good, but we still need a second reviewer.

Cheers,
Stefan

On 2018-09-04 03:37, Man Cao wrote:
> Hi all,
> 
> Thanks, Stefan! I have added a test for the hsperf counter. The test is 
> based on test/hotspot/jtreg/gc/TestGenerationPerfCounter.java.
> New webrev:
> http://cr.openjdk.java.net/~jcbeyler/8210192/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ejcbeyler/8210192/webrev.01/>
> 
> I have run some basic tests with "make run-test", and those related 
> to test/hotspot/jtreg/gc/testlibrary/PerfCounter.java are still passing.
> 
> Thanks,
> Man
> 
> On Friday, August 31, 2018, Stefan Johansson 
> <stefan.johansson at oracle.com <mailto:stefan.johansson at oracle.com>> wrote:
> 
>     On 2018-08-31 02:07, Man Cao wrote:
> 
>         Thanks for the review!
>         Should we wait for another "looks good" before JC can submit it?
> 
>     Yes, we should wait to get a second review.
> 
>         Since the testing infrastructure did not catch this change,
>         should we add a test for this hsperf counter?
> 
>     That would probably be good, please look at the other counter tests
>     and create something similar to that. Once you have the test I can
>     apply the patch and run it through our test system to make sure it
>     passes on all platforms.
> 
>     Thanks,
>     Stefan
> 
> 
>         PS: I found a better command to test for its value:
>         $ jstat -J-Djstat.showUnsupported=true -snap
>         file:///$(pwd)/test.hsperf | grep sun.gc.policy.name
>         <http://sun.gc.policy.name> <http://sun.gc.policy.name>
> 
>         -Man
> 
> 
>         On Thu, Aug 30, 2018 at 1:52 AM Stefan Johansson
>         <stefan.johansson at oracle.com
>         <mailto:stefan.johansson at oracle.com>
>         <mailto:stefan.johansson at oracle.com
>         <mailto:stefan.johansson at oracle.com>>> wrote:
> 
> 
> 
>              On 2018-08-30 02:29, Man Cao wrote:
>               > Hi all,
>               >
>               > I noticed a possible slight naming bug for the HSPerf
>               > counter "sun.gc.policy.name <http://sun.gc.policy.name>
>         <http://sun.gc.policy.name>
>              <http://sun.gc.policy.name>", introduced by
>               > http://hg.openjdk.java.net/jdk/jdk/rev/170c7b36aea6
>         <http://hg.openjdk.java.net/jdk/jdk/rev/170c7b36aea6>.
>               >
>               > Basically instead of "ParNew:CMS", the counter's value
>         is now
>              "ParNew::CMS".
>               >
>               > Here is a fix for the bug, could someone review it?
>               >
>               > Webrev:
>         http://cr.openjdk.java.net/~jcbeyler/8210192/webrev.00/
>         <http://cr.openjdk.java.net/%7Ejcbeyler/8210192/webrev.00/>
>              <http://cr.openjdk.java.net/%7Ejcbeyler/8210192/webrev.00/
>         <http://cr.openjdk.java.net/%7Ejcbeyler/8210192/webrev.00/>>
>               >
>         <http://cr.openjdk.java.net/%7Ejcbeyler/8210192/webrev.00/
>         <http://cr.openjdk.java.net/%7Ejcbeyler/8210192/webrev.00/>>
>               > Bug: https://bugs.openjdk.java.net/browse/JDK-8210192
>         <https://bugs.openjdk.java.net/browse/JDK-8210192>
> 
>              Looks good and since the bug hasn't shown up in our testing
>         I don't
>              think fixing it back should be a problem testing wise.
> 
>              Thanks,
>              StefanJ
> 
>               >
>               > PS: Thanks JC for creating the bug and hosting the webrev!
>               >
>               > Thanks!
>               > Man
> 
> 
> 
> -- 
> -Man
> 


More information about the hotspot-gc-dev mailing list