RFR (XS) 8210192: Hsperf counter ParNew::CMS should be ParNew:CMS

JC Beyler jcbeyler at google.com
Tue Sep 4 21:25:49 UTC 2018


Hi all,

I created the webrev with the metadata here:
http://cr.openjdk.java.net/~jcbeyler/8210192/webrev.02/

I pushed the fix since Thomas & Stefan reviewed it. I added Man as the
contributor and ensured it built and passed the new test on my side (which
with Stefan's testing seemed to be sufficient).

Thanks Man for the fix and Thomas and Stefan for the reviews :)
Jc

On Tue, Sep 4, 2018 at 6:25 AM Thomas Schatzl <thomas.schatzl at oracle.com>
wrote:

> Hi,
>
> On Mon, 2018-09-03 at 18:37 -0700, Man Cao wrote:
> > Hi all,
> >
> > Thanks, Stefan! I have added a test for the hsperf counter. The test
> > is based on test/hotspot/jtreg/gc/TestGenerationPerfCounter.java.
> > New webrev:
> > http://cr.openjdk.java.net/~jcbeyler/8210192/webrev.01/
> >
> > I have run some basic tests with "make run-test", and those related
> > to test/hotspot/jtreg/gc/testlibrary/PerfCounter.java are still
> > passing.
> >
>
>   looks good.
>
> Thomas
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20180904/0d56bbad/attachment.html>


More information about the hotspot-gc-dev mailing list