RFR: 8196341: Add JFR events for parallel phases of G1

Leo Korinth leo.korinth at oracle.com
Tue Sep 11 13:59:37 UTC 2018


On 11/09/18 14:59, Thomas Schatzl wrote:
> Hi Leo,
> 
> On Wed, 2018-09-05 at 14:27 +0200, Leo Korinth wrote:
>> Hi,
>>
>> I have added JFR events for the parallel phases of G1.
>>
>> This change adds JFR events for most values of the enumeration
>> GCParPhases. I have also added a test case
>> (TestG1ParallelPhases.java).
>>
>> This is a rebase/rework of a previous post I did 31th of January
>> that
>> never got pushed.
>>
>> Enhancement:
>> https://bugs.openjdk.java.net/browse/JDK-8196341
>>
>> Webrev:
>> http://cr.openjdk.java.net/~lkorinth/8196341/00/
>>
>> Testing:
>> - mach5 hs-tier1,hs-tier2,hs-tier3
>> - brief visual inspection of result in JMC
>> - new test TestG1ParallelPhases.java (100 runs)
> 
>    looks good.
> 
> We discussed this in private earlier, please consider implementing some
> way to wrap JFR events in scoped objects. That would make the code much
> simpler to read, and easier to add JFR events in the future too.

Yes, I agree. In the future I will probably add constructors to all JFR 
events so that they can be directly assigned to a scoped object. The 
other way of adding commit() on destruction of the JFR events directly 
was not considered as easy to read when I talked to the JFR people.

> However this seems out of scope for this particular change.
> 
> Thanks,
>    Thomas
> 

Thanks for your review Thomas.

/Leo


More information about the hotspot-gc-dev mailing list