RFR: 8210711: Remove unused offset getters in ThreadLocalAllocBuffer

Per Liden per.liden at oracle.com
Thu Sep 13 12:13:36 UTC 2018


Thanks Martin!

/Per

On 09/13/2018 01:55 PM, Doerr, Martin wrote:
> Hi Per,
> 
> looks good to me, too.
> 
> Best regards,
> Martin
> 
> -----Original Message-----
> From: hotspot-gc-dev <hotspot-gc-dev-bounces at openjdk.java.net> On Behalf Of Per Liden
> Sent: Donnerstag, 13. September 2018 13:23
> To: Roman Kennke <rkennke at redhat.com>; hotspot-gc-dev <hotspot-gc-dev at openjdk.java.net>
> Subject: Re: RFR: 8210711: Remove unused offset getters in ThreadLocalAllocBuffer
> 
> Thanks for reviewing, Roman!
> 
> /Per
> 
> On 09/13/2018 01:17 PM, Roman Kennke wrote:
>> Good by me. Thanks!
>> Roman
>>
>>
>>> The following offset getters in ThreadLocalAllocBuffer are unused and
>>> can be removed. They are left-overs from when we had FastTLABRefill
>>> support. I stumbled over these when working on an unrelated TLAB change,
>>> so I broke this out into a separate patch.
>>>
>>> static ByteSize size_offset();
>>> static ByteSize refill_waste_limit_offset();
>>> static ByteSize number_of_refills_offset();
>>> static ByteSize fast_refill_waste_offset();
>>> static ByteSize slow_allocations_offset();
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210711
>>> Webrev: http://cr.openjdk.java.net/~pliden/8210711/webrev.0
>>>
>>> /Per
>>
>>


More information about the hotspot-gc-dev mailing list