RFR: 8196341: Add JFR events for parallel phases of G1

sangheon.kim at oracle.com sangheon.kim at oracle.com
Tue Sep 18 19:14:22 UTC 2018


Hi Leo,

On 9/18/18 8:10 AM, Leo Korinth wrote:
> Hi, could I get another review on this?
>
> Thanks, Leo
>
> On 05/09/18 14:27, Leo Korinth wrote:
>> Hi,
>>
>> I have added JFR events for the parallel phases of G1.
>>
>> This change adds JFR events for most values of the enumeration 
>> GCParPhases. I have also added a test case (TestG1ParallelPhases.java).
>>
>> This is a rebase/rework of a previous post I did 31th of January that 
>> never got pushed.
>>
>> Enhancement:
>> https://bugs.openjdk.java.net/browse/JDK-8196341
>>
>> Webrev:
>> http://cr.openjdk.java.net/~lkorinth/8196341/00/
This looks good to me.
And agree to Thomas about scoped objects suggestion.

Thanks,
Sangheon


>>
>> Testing:
>> - mach5 hs-tier1,hs-tier2,hs-tier3
>> - brief visual inspection of result in JMC
>> - new test TestG1ParallelPhases.java (100 runs)
>>
>> Thanks,
>> Leo



More information about the hotspot-gc-dev mailing list