RFR (S) [8u] backport 8141421: Various test fail with OOME on win x86

David Buck david.buck at oracle.com
Wed Sep 26 08:06:25 UTC 2018


Hi Thomas!

Thank you for the review.

Out of an (almost pathological) abundance of caution, here an updated 
webrev:

http://cr.openjdk.java.net/~dbuck/8141421_hotspot_jdk8_ver02/

Would you mind taking one last look at the indentation?

Cheers,
-Buck


On 2018/09/26 16:45, Thomas Schatzl wrote:
> Hi David,
> 
> On Tue, 2018-09-25 at 10:37 +0900, David Buck wrote:
>> Hi!
>>
>> May I please get a review of this simple backport to 8u-dev? The
>> only reason the JDK 9 fix does not apply as-is to JDK 8 is because of
>> changes to assert in JDK 9 [0].
>>
>> bug report:
>> https://bugs.openjdk.java.net/browse/JDK-8141421
>>
>> JDK 9 review thread:
>> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-January/01
>> 6251.html
>>
>> JDK 9 changeset:
>> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/2de6311c5afc
>>
>> JDK 8 webrev (for review):
>> http://cr.openjdk.java.net/~dbuck/8141421_hotspot_jdk8_ver01/
>>
>> Cheers,
>> -Buck
>>
>> [0] https://bugs.openjdk.java.net/browse/JDK-8080775
>>
> 
>    looks good.
> 
> Could you fix indentation of the assert texts so that the part within
> the err_msg() call is aligned correctly? So instead of:
> 
> assert(someCondition,
>         err_msg("....",
>         arg1, arg2, ...));
> 
> use
> 
> assert(someCondition,
>         err_msg("....",
>                 arg1, arg2, ....));
> 
> 
> to make it more readable (in heapRegionRemSet.cpp, twice).
> 
> I do not need to see a re-review, but if jdk8u review guidelines tell
> so, I will certainly look at these minor updates again.
> 
> Thanks,
>    Thomas
> 


More information about the hotspot-gc-dev mailing list