RFR (S) 8211228: Zero build is broken after JDK-8196341 (Add JFR events for parallel phases of G1)

Markus Gronlund markus.gronlund at oracle.com
Fri Sep 28 20:03:03 UTC 2018


Hi Aleksey,

I am currently travelling and I have not been following this in detail.

As I understand it, JDK-8196341, extended the signatures for the commit() methods, but the associated !INCLUDE_JFR section was not updated, causing compilation errors.

I have not checked everything in detail, but it seems the fix does add those missing signature(s).

I am ok with this from a JFR perspective.

Thanks for addressing
Markus


-----Original Message-----
From: Aleksey Shipilev <shade at redhat.com> 
Sent: den 27 september 2018 14:16
To: hotspot-gc-dev at openjdk.java.net
Subject: Re: RFR (S) 8211228: Zero build is broken after JDK-8196341 (Add JFR events for parallel phases of G1)

On 09/27/2018 03:55 PM, Aleksey Shipilev wrote:
> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8211228
> 
> Fix:
>   http://cr.openjdk.java.net/~shade/8211228/webrev.01/
> 
> Recent addition of JFR events to G1 broke Zero build. That is because 
> Zero builds with JFR disabled, but G1 enabled (it is a separate 
> question why!). It can be fixed by putting JFR_ONLY all around 
> JFR-specific code, or by configuring Zero to avoid building g1gc. But, since it looks like AIX is also affected by this:
>   https://bugs.openjdk.java.net/browse/JDK-8211213

I retract this RFR in favor of proper fix on JFR side:
  https://bugs.openjdk.java.net/browse/JDK-8211239

-Aleksey



More information about the hotspot-gc-dev mailing list