RFR(S) 8212127: Cleanup TLAB fast refill statistics, perf counters and etc.

zgu at redhat.com zgu at redhat.com
Wed Feb 6 14:34:11 UTC 2019


Thanks, Aleksey.

On Wed, 2019-02-06 at 15:23 +0100, Aleksey Shipilev wrote:
> On 2/3/19 10:43 PM, zgu at redhat.com wrote:
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8212127
> > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8212127/webrev.00/
> 
> Looks fine code-wise.
> 
> *) In src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp, why
> this whole thing is removed? I
> would expect "just" the rename of slow_refill_waste() to
> refill_waste() and removing
> fast_refill_waste() here, leaving everything else untouched.
> 
>  105   // statistics
>  106
>  107   int number_of_refills() const { return _number_of_refills; }
>  108   int fast_refill_waste() const { return _fast_refill_waste; }
>  109   int slow_refill_waste() const { return _slow_refill_waste; }
>  110   int gc_waste() const          { return _gc_waste; }
>  111   int slow_allocations() const  { return _slow_allocations; }
>  112

They are dead code. Do they worth for another cleanup RFE for the
trivial cleanup?

-Zhengyu

> 
> 
> Thanks,
> -Aleksey
> 


More information about the hotspot-gc-dev mailing list