RFR (XXS): 8218680: G1 crashes during calculation of old collection set candidates

Thomas Schatzl thomas.schatzl at oracle.com
Mon Feb 11 11:40:26 UTC 2019


On Mon, 2019-02-11 at 12:32 +0100, Thomas Schatzl wrote:
> Hi all,
> 
>   can I have reviews for this one-liner fix caused by passing

(originally it had been a one-liner, but then I thought that it would
be nicer to fix the order of parameters in the declarations to keep
them in line with other uses than just changing the order in the call
to the G1BuildCandidateArray constructor).

> parameters in the wrong order to some internal data structure during
> calculation of old collection set candidates?
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8218680
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8218680/webrev
> Testing:
> The very quickly (<1min, right the first time it calculates old
> collection set candidates) crashing application, BigRAMTester, now
> runs more than 30mins.

There is no additional regression test at this time because later CI
tests not checked in the initial commit (tier7) also fail with the same
assert.

I may be able to come up with a separate regression test if needed, but
I think the problem and the fix is relatively trivial. If you insist I
would prefer to do a regression test as a separate CR to remove the
noise from our testing.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list