RFR: 8218732: SA: Resolves ZPageAllocator::_physical incorrectly

Jini George jini.george at oracle.com
Mon Feb 11 18:00:04 UTC 2019


Hi Stefan,

Looks good to me overall. One point though.

physicalFieldOffset = type.getAddressField("_physical").getOffset();

Wrt the line above, is there any reason due to which getAddressField() 
instead of getField() was used ? getAddressField() is typically used 
when the field to be read in is a pointer. I feel getField() might be 
more appropriate in this situation.

Thanks,
Jini.

On 2/11/2019 1:23 PM, Stefan Karlsson wrote:
> Hi all,
> 
> Please review this small patch to resolve ZPageAllocator::_physical as a 
> value object instead of a pointer.
> 
> https://cr.openjdk.java.net/~stefank/8218732/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8218732
> 
> This fixes the Heap Parameters view.
> 
> Thanks,
> StefanK


More information about the hotspot-gc-dev mailing list