RFR: 8218732: SA: Resolves ZPageAllocator::_physical incorrectly
erik.osterlund at oracle.com
Thu Feb 14 08:26:40 UTC 2019
Given that the remark from Jini is fixed, this looks good. I don't need
On 2019-02-11 19:09, Stefan Karlsson wrote:
> Hi Jini,
> On 2019-02-11 19:00, Jini George wrote:
>> Hi Stefan,
>> Looks good to me overall. One point though.
>> physicalFieldOffset = type.getAddressField("_physical").getOffset();
>> Wrt the line above, is there any reason due to which getAddressField()
>> instead of getField() was used ? getAddressField() is typically used
>> when the field to be read in is a pointer. I feel getField() might be
>> more appropriate in this situation.
> No, this is just an oversight. I have the same issue in my later
> OopHandle patch. I'll change this.
> Thanks for reviewing,
>> On 2/11/2019 1:23 PM, Stefan Karlsson wrote:
>>> Hi all,
>>> Please review this small patch to resolve ZPageAllocator::_physical
>>> as a value object instead of a pointer.
>>> This fixes the Heap Parameters view.
More information about the hotspot-gc-dev