RFR (S): 8219098: Make output of region strings more regular in error messages

Kim Barrett kim.barrett at oracle.com
Fri Feb 15 20:47:03 UTC 2019


> On Feb 15, 2019, at 8:51 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi all,
> 
>  can I have reviews for this change that improves (regularizes) the
> output of verification error messages to use the existing
> HR_FORMAT/HR_FORMAT_PARAMS that include the HeapRegion number instead
> of fixing this in every message?
> 
> The HeapRegion number is much more easy to read and understand than a
> set of addresses.
> 
> I.e. this has been the n-th time I had added region numbers to these
> messages manually while debugging some other changes, and so I thought
> it would be worthwhile fixing this in mainline.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8219098
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8219098/webrev/
> Testing:
> compilation
> 
> Thanks,
>  Thomas

Looks good.



More information about the hotspot-gc-dev mailing list