RFR(T): 8219232: Unit of concurrent active time logging is wrong

Aleksey Shipilev shade at redhat.com
Mon Feb 18 14:13:31 UTC 2019


On 2/18/19 3:08 PM, Tobias Hartmann wrote:
> diff -r 2a78b2963793 src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp
> --- a/src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp	Wed Feb 13 13:27:17 2019 +0100
> +++ b/src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp	Mon Feb 18 15:05:56 2019 +0100
> @@ -2761,7 +2761,7 @@
>  CMSPhaseAccounting::~CMSPhaseAccounting() {
>    _collector->gc_timer_cm()->register_gc_concurrent_end();
>    _collector->stopTimer();
> - log_debug(gc)("Concurrent active time: %.3fms",
> TimeHelper::counter_to_seconds(_collector->timerTicks()));
> + log_debug(gc)("Concurrent active time: %.3fms",
> TimeHelper::counter_to_millis(_collector->timerTicks()));
>    log_trace(gc)(" (CMS %s yielded %d times)", _title, _collector->yields());
>  }

Looks good to me. I assume you have eyeballed the output to make sense now?

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190218/e119bbe5/signature.asc>


More information about the hotspot-gc-dev mailing list