RFR (XS): 8218672: AOT code root scanning shows in the wrong position in the logs

Thomas Schatzl thomas.schatzl at oracle.com
Tue Feb 19 11:45:14 UTC 2019


Hi Leo, Kim,

On Fri, 2019-02-15 at 16:23 -0500, Kim Barrett wrote:
> > On Feb 15, 2019, at 8:27 AM, Thomas Schatzl <
> > thomas.schatzl at oracle.com> wrote:
> > 
> > Hi all,
> > 
> >  can I have reviews for this small change that fixes the position
> > of the "AOT Code Root Scan" phase, moving it to appear under the
> > "Ext Root Scan" phase where it is handled in?
> > 
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8218672
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8218672/webrev/
> > Testing:
> > hs-tier5 (there is some jfr test case that complains if the phase
> > names
> > were messed up)
> > 
> > Thanks,
> >  Thomas
> 
> Looks good.
> 

  thanks for your review.

> It took a while for me to figure out where the printing of the AOT
> Code Roots time had gone. It might be nice to have a couple of named
> constants for the range of ExtRootScan sub-phases, for use as the
> iteration bounds in print_evacuate_collection_set.

  I will add these in a separate CR.

Thomas




More information about the hotspot-gc-dev mailing list