RFR (S/M): 8219096: Merge print_termination_stats code with current logging

Leo Korinth leo.korinth at oracle.com
Tue Feb 19 14:52:19 UTC 2019


Hi!

On 15/02/2019 14:43, Thomas Schatzl wrote:
> Hi,
> 
>    can I have reviews for this change that merges the termination
> statistics into the regular log file (there were only two metrics left,
> LAB waste and LAB undo waste), and remove the termination stats
> afterwards?
> 
> I (very) rarely use these metrics, so I thought it would be better to
> keep them (and not just removing the entire termination stats).
> 
> I was undecided whether it would be good to hide these under the
> gc+phases=trace level though, so opinions welcome.

I have no opinion on this.

However, I dislike the conversion from heap words to bytes in the middle 
of everything. I would prefer to have the conversion as early as 
possible, or maybe better, as late as possible (as it was before). It is 
easy to miss that size_t G1ParScanThreadState::lab_waste() and size_t 
G1PLABAllocator::waste() use different "units". However if this was done 
on purpose with good reasons, just ignore my comment.

That, and update copyrights and the change looks good to me.

Thanks,
Leo
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8219096
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8219096/webrev/
> Testing:
> log output verification, test case update
> 
> Thanks,
>    Thomas
> 
> 


More information about the hotspot-gc-dev mailing list