RFR (S/M): 8219096: Merge print_termination_stats code with current logging
leo.korinth at oracle.com
Tue Feb 19 14:52:19 UTC 2019
On 15/02/2019 14:43, Thomas Schatzl wrote:
> can I have reviews for this change that merges the termination
> statistics into the regular log file (there were only two metrics left,
> LAB waste and LAB undo waste), and remove the termination stats
> I (very) rarely use these metrics, so I thought it would be better to
> keep them (and not just removing the entire termination stats).
> I was undecided whether it would be good to hide these under the
> gc+phases=trace level though, so opinions welcome.
I have no opinion on this.
However, I dislike the conversion from heap words to bytes in the middle
of everything. I would prefer to have the conversion as early as
possible, or maybe better, as late as possible (as it was before). It is
easy to miss that size_t G1ParScanThreadState::lab_waste() and size_t
G1PLABAllocator::waste() use different "units". However if this was done
on purpose with good reasons, just ignore my comment.
That, and update copyrights and the change looks good to me.
> log output verification, test case update
More information about the hotspot-gc-dev