RFR (S): 8219098: Make output of region strings more regular in error messages

Leo Korinth leo.korinth at oracle.com
Tue Feb 19 15:55:37 UTC 2019


Hi!

Thanks for making output more regular, change looks great except update 
of copyright years.

Maybe you should do a fast visual examination of logs if you have not 
already done that, format string errors are easy to make...

Thanks,
Leo


On 15/02/2019 14:51, Thomas Schatzl wrote:
> Hi all,
> 
>    can I have reviews for this change that improves (regularizes) the
> output of verification error messages to use the existing
> HR_FORMAT/HR_FORMAT_PARAMS that include the HeapRegion number instead
> of fixing this in every message?
> 
> The HeapRegion number is much more easy to read and understand than a
> set of addresses.
> 
> I.e. this has been the n-th time I had added region numbers to these
> messages manually while debugging some other changes, and so I thought
> it would be worthwhile fixing this in mainline.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8219098
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8219098/webrev/
> Testing:
> compilation
> 
> Thanks,
>    Thomas
> 


More information about the hotspot-gc-dev mailing list