RFR (S/M): 8219096: Merge print_termination_stats code with current logging

Leo Korinth leo.korinth at oracle.com
Wed Feb 20 13:21:55 UTC 2019


Looks good!

Thanks,
Leo


On 20/02/2019 10:33, Thomas Schatzl wrote:
> Hi,
> 
> On Tue, 2019-02-19 at 15:52 +0100, Leo Korinth wrote:
>> Hi!
>>
>> On 15/02/2019 14:43, Thomas Schatzl wrote:
>>> Hi,
>>>
>>>     can I have reviews for this change that merges the termination
>>> statistics into the regular log file (there were only two metrics
>>> left, LAB waste and LAB undo waste), and remove the termination
>>> stats afterwards?
>>>
>>> I (very) rarely use these metrics, so I thought it would be better
>>> to keep them (and not just removing the entire termination stats).
>>>
>>> I was undecided whether it would be good to hide these under the
>>> gc+phases=trace level though, so opinions welcome.
>>
>> I have no opinion on this.
>>
>> However, I dislike the conversion from heap words to bytes in the
>> middle of everything. I would prefer to have the conversion as early
>> as possible, or maybe better, as late as possible (as it was before).
>> It is easy to miss that size_t G1ParScanThreadState::lab_waste() and
>> size_t G1PLABAllocator::waste() use different "units". However if
>> this was done on purpose with good reasons, just ignore my comment.
>>
>> That, and update copyrights and the change looks good to me.
> 
> All fixed in
> http://cr.openjdk.java.net/~tschatzl/8219096/webrev.0_to_1 (diff)
> http://cr.openjdk.java.net/~tschatzl/8219096/webrev.1 (full)
> 
> Thanks,
>    Thomas
> 
> 


More information about the hotspot-gc-dev mailing list