[11u] RFR (S) 8214118: HeapRegions marked as archive even if CDS mapping fails

Jiangli Zhou jianglizhou at google.com
Fri Feb 22 15:47:23 UTC 2019


Hi Aleksey,

The backport looks good to me.

On Fri, Feb 22, 2019 at 1:48 AM Aleksey Shipilev <shade at redhat.com> wrote:

> Please review the backport to 11u.
>
> Original bug:
>   https://bugs.openjdk.java.net/browse/JDK-8214118
>
> Original fix:
>   http://hg.openjdk.java.net/jdk/jdk/rev/c9325aa887da
>
> The patch does not apply cleanly to 11u, because there are minute
> differences in the code. Notably,
> there is no closed_archive_heap_ranges, and as I see from the code,
> string_ranges is the old name
> for it. It was renamed in JDK-8212995.
>

Right.  The renaming happened when graphs of non-string objects were
supported in the closed region.

Thanks,
Jiangli


> I also see there is Oracle-closed backport to 11u-oracle, can we compare
> the patches with Oracle
> folks, maybe?
>
> 11u webrev:
>   http://cr.openjdk.java.net/~shade/8214118/webrev.11u.01/
>
> Testing: Linux x86_64 tier1
>
> Thanks,
> -Aleksey
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190222/32c5f7b7/attachment.html>


More information about the hotspot-gc-dev mailing list